v.g.vassilev added inline comments.
================ Comment at: clang/lib/Interpreter/Interpreter.cpp:144-146 ClangArgv.insert(ClangArgv.end(), "-Xclang"); ClangArgv.insert(ClangArgv.end(), "-fincremental-extensions"); ClangArgv.insert(ClangArgv.end(), "-c"); ---------------- Hahnfeld wrote: > This doesn't do what the comments claim - it appends at the end, not > prepends. For that it would need to be `ClangArgv.insert(ClangArgv.begin(), > "-c")`. @v.g.vassilev what do we want here? (probably doesn't block this > revision, but it's odd nevertheless) Yeah, this forces the clang::Driver to have some sort of action. In turn, this helps produce diagnostics from the driver before failing. That's a known bug since the early days of clang that nobody addressed... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146389/new/ https://reviews.llvm.org/D146389 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
