carlosgalvezp accepted this revision. carlosgalvezp added a comment. Having another look and reading your comments I got a better understanding of the situation:
- YAML output did not have correct warnings as errors. - Thus a fix was introduced in ClangTidyDiagnosticConsumer, however this was a too broad place to put the fix, breaking diagnostics output by command-line. - Instead, the fix should have been put in a narrower scope, in the part of the code that deals with YAML output. - This patch does exactly that. So this patch is not really altering the original diagnostic behavior. In that sense I'm ok with it! I suppose it would have been clearer from a review perspective if first a revert was made and then re-landed with the correct code, but it's probably too much annoyance for such a small change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
