carlosgalvezp added a comment.

Reading through Github I found the associated ticket (it would be good if you 
could mention it in the commit message):
https://github.com/llvm/llvm-project/issues/61520

So if I understand correctly, what you are trying to do is continue to let the 
clang-analyzer-core checks run, and simply ignore the warnings coming from them 
when enabling `warnings_as_errors`. I'm not entirely convinced that's the best 
approach, it's hiding the real problem - that as a user one cannot disable 
clang-analyzer-core checks (which is being fixed in another patch by PiotrZSL). 
I also find strange to move error-handling logic away from the 
DiagnosticConsumer class out to the main ClangTidy class.

Would be good if @njames93  or @aaron.ballman  could comment on this, given 
their experience.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146520/new/

https://reviews.llvm.org/D146520

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to