jrmolin added a comment.
I think I have hit all the requests now. We're in the middle of building
release candidates and testing, so management is taking longer and longer to
get back to me about a style guide for my team.
We added it, because it forces a consistent look across all function
declarations. I don't know what the next steps are now. I'm stuck; you're
stuck. :shrug:
================
Comment at: clang/lib/Format/TokenAnnotator.cpp:4742-4748
+ if (Left.is(tok::l_paren) && Style.AlwaysBreakBeforeFunctionParameters &&
+ !Right.is(tok::r_paren) && Left.Previous) {
+ const FormatToken &TwoPrevious = *Left.Previous;
+ if (TwoPrevious.is(TT_FunctionDeclarationName)) {
+ return true;
+ }
+ }
----------------
HazardyKnusperkeks wrote:
> jrmolin wrote:
> > HazardyKnusperkeks wrote:
> > > That I meant with merge.
> > Ah, understood. I generally don't collapse `if`s, so I didn't know how much
> > you wanted. It seems like ... all of it.
> I think now you need to format it.
I ran the formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125171/new/
https://reviews.llvm.org/D125171
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
