erichkeane added a comment.
This generally looks good to me, but I get lost in the parser pretty quick, so
hoping one of the other reviewers can take a look.
================
Comment at: clang/test/Parser/cxx-template-template-recovery.cpp:27
+
+static_assert(test<a::C1>); //expected-error {{too few template arguments for
concept 'C1'}}
+static_assert(test<a::b::C2>); //expected-error {{too few template arguments
for concept 'C2'}}
----------------
So it appears that lines 27 and 28 are the only behavioral changes here, right?
The line 31 and 37 sections are the same, right?
1 Nit here: I REALLY prefer when we use bookmarks, and include the notes next
to their diagnostic. Here it isn't hugely necessary, but still a preference if
you're needing to update this again.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146719/new/
https://reviews.llvm.org/D146719
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
