zyounan added inline comments.
================ Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:60 +bool shouldPatchPlaceholder0(CodeCompletionResult::ResultKind ResultKind, + CXCursorKind CursorKind) { ---------------- nridge wrote: > nit: let's add a short comment to describe the function, such as: > > ``` > // Determine whether the completion string should be patched > // to replace the last placeholder with $0 > ``` Sure! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits