AryanGodara added a comment. In D146041#4195992 <https://reviews.llvm.org/D146041#4195992>, @DavidSpickett wrote:
>> Since this is my first commit to such a large repository(and project), can >> you please guide me with this @DavidSpickett ! > > Sure, you'll want to make a commit that only has changes to warnings and > errors. You can split up this one to do that, see part "A)" of this answer > https://stackoverflow.com/questions/6217156/break-a-previous-commit-into-multiple-commits/6217314#6217314. > Then you can update this review with that new commit, change the > description/title etc. if needed. > > If you get confused with updating the review (happens to me all the time) you > can just abandon this (there is an entry in the "Add Action..." menu) and > make a new review as you did before. > > How to identify what changes should be included? I would ignore comments, > shell scripts, FIXMEs, or general test data. If the test is producing a > warning and looking for it, clearly it should be changed. If it's just random > data it's using to test some function, I wouldn't change it. Thanks for the info @DavidSpickett !! I will try to split this commit, and update on this asap (Sorry for the late update, I have mid-sem exams going on, I haven't abandoned this issue, still working on it). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146041/new/ https://reviews.llvm.org/D146041 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
