AryanGodara added a comment.

In D146041#4193045 <https://reviews.llvm.org/D146041#4193045>, @DavidSpickett 
wrote:

> Is there some standard for writing warning messages? For llvm that is, it 
> would be worth looking through the getting started guides to see. I think the 
> majority of warnings are "formal" in that sense so this seems fine.
>
> Personally I agree with making the warnings more succinct but aside from that 
> I don't see the need to change comments or testing scripts.
>
> You may consider splitting this change into 2. One that only changes warnings 
> and errors (a less controversial change) and the rest (that is up to the 
> reviewers of each bit).

I will do go through the changes I made, and first make sure to change only 
warnings and errors.

Since this is my first commit to such a large repository(and project), can you 
please guide me with this  @DavidSpickett !


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146041/new/

https://reviews.llvm.org/D146041

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to