balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land.
There are some unresolved comments in the test (cast is not needed at `Import` and `EXPECT_TRUE` can be used) but otherwise LGTM. (But I have a feeling that problems may happen with attributes like `GuardedByAttr` if these are imported before the field is added to the record. Probably it is better to only import the `NoUniqueAddressAttr` in `VisitFieldDecl`.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145057/new/ https://reviews.llvm.org/D145057 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits