kpdev42 marked 2 inline comments as done.
kpdev42 added inline comments.

================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:8161
+    EXPECT_EQ(true, FD->hasAttr<NoUniqueAddressAttr>());
+}
+
----------------
balazske wrote:
> Does this test fail without the changes applied? And does it not fail after 
> (is the "Empty" value copied at import)?
Yes the tests will fail due to above mentioned problem with field attributes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145057/new/

https://reviews.llvm.org/D145057

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to