samitolvanen accepted this revision. samitolvanen added a comment. LGTM. Folding D145979 <https://reviews.llvm.org/D145979> into this one might also make sense.
================ Comment at: clang/test/Driver/riscv-fixed-x-register.c:343 + +// Check that x18 is reserved on Android by default +// RUN: %clang --target=riscv64-linux-android -### %s 2> %t ---------------- This seems redundant. Isn't the LLVM codegen test sufficient here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145999/new/ https://reviews.llvm.org/D145999 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
