yaxunl added inline comments.
================ Comment at: clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl:381 +// GFX900-LABEL: define {{[^@]+}}@callee +// GFX900-SAME: (i64 noundef [[ID:%.*]], ptr addrspace(1) noundef [[OUT:%.*]]) #[[ATTR1:[0-9]+]] { +// GFX900-NEXT: entry: ---------------- these attributes are not really checked since ATTR1 etc are not used to check the attributes definitions. Is this a bug of update_cc_test_checks.py ? Or it is expected to be manually edited to enforce the checking? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141620/new/ https://reviews.llvm.org/D141620 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits