arsenm added inline comments.
================
Comment at: clang/test/CodeGenOpenCL/cl20-device-side-enqueue-attributes.cl:26
+// SPIR32-SAME: (ptr addrspace(1) align 4 [[A:%.*]], ptr addrspace(1) align 4
[[B:%.*]], i32 [[I:%.*]]) #[[ATTR0:[0-9]+]] !kernel_arg_addr_space !2
!kernel_arg_access_qual !3 !kernel_arg_type !4 !kernel_arg_base_type !4
!kernel_arg_type_qual !5 {
+// SPIR32-NEXT: entry:
+// SPIR32-NEXT: [[A_ADDR:%.*]] = alloca ptr addrspace(1), align 4
----------------
Anastasia wrote:
> `ATTR0` seems to be set but never used.
>
> Do we need to be checking the output of the whole function body?
>
> I imagine checking the function definition and attributes should be enough
> for this patch?
>
Yes, but I don't think update_cc_test_checks has that option
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141620/new/
https://reviews.llvm.org/D141620
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
