ilinpv added inline comments.
================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:115
+AARCH64_ARCH_EXT_NAME("rdm", AArch64::AEK_RDM, "+rdm",
"-rdm", \
+RDM, "+rdm,+fp-armv8,+neon,+jsconv,+complxnum",
70)
+AARCH64_ARCH_EXT_NAME("crypto", AArch64::AEK_CRYPTO, "+crypto",
"-crypto", \
----------------
dmgreen wrote:
> ilinpv wrote:
> > dmgreen wrote:
> > > Should RDM be dependant on +jsconv,+complxnum?
> > I suppose RDM implies simd (+neon) which implies +jsconv,+complxnum
> jsconv and complxnum are 8.3 features, are they not? Or do they somehow mean
> something different here? It would seem strange for neon to depend on them.
Right, last implication is true from 8.3, and wrong before that, thanks for
spotting that! I will fix that in other places too.
```
FEAT_JSCVT implements the functionality identified by 0b0001.
In Armv8.0, Armv8.1, and Armv8.2, the only permitted value is 0b0000.
From Armv8.3, if Advanced SIMD or Floating-point is implemented, the only
permitted value is 0b0001.
From Armv8.3, if Advanced SIMD or Floating-point is not implemented, the only
permitted value is 0b0000.
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127812/new/
https://reviews.llvm.org/D127812
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
