arsenm added inline comments.
================
Comment at: clang/lib/Basic/Targets/AMDGPU.h:119
+ bool hasBFloat16Type() const override { return isAMDGCN(getTriple()); }
+ const char *getBFloat16Mangling() const override { return "u6__bf16"; };
+
----------------
Pierre-vh wrote:
> Pierre-vh wrote:
> > arsenm wrote:
> > > Don't understand this mangling. What is u6?
> > Not sure; for that one I just copy-pasted the implementation of other
> > targets. All other targets use that mangling scheme
> Ah I remember now, it's just C++ mangling. I don't quite understand the
> lowercase "u" but a quick search in Clang tells me it's vendor-extended types.
> So it's just u6 -> vendor extended type, 6 characters following + __bf16
> (name of the type).
Do we really need an override for this? I'd expect a reasonable default. Plus I
think a virtual function for something that's only a parameterless, static
string is a bit ridiculous
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139398/new/
https://reviews.llvm.org/D139398
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
