tbaeder marked 3 inline comments as done.
tbaeder added inline comments.
================
Comment at: clang/lib/AST/Interp/Interp.cpp:447
+
+ if (FieldType->isRecordType()) {
+ Result &= CheckFieldsInitialized(S, OpPC, FieldPtr,
FieldPtr.getRecord());
----------------
aaron.ballman wrote:
> Do we have to worry about static data members, or are those excluded in
> `fields()`?
They aren't in `RecordDecl::fields()`, so aren't in `Record::fields()` either.
================
Comment at: clang/lib/AST/Interp/Interp.h:1346-1347
if (Func->hasThisPointer()) {
+ ThisPtr = NewFrame->getThis();
if (!CheckInvoke(S, PC, NewFrame->getThis())) {
return false;
----------------
aaron.ballman wrote:
> Should we assert that `ThisPtr` is valid?
We could only assert `!isZero()` as far as I understand, but that's part of
what `CheckInvoke` does.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136694/new/
https://reviews.llvm.org/D136694
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
