aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: clang/lib/AST/Interp/Interp.h:1346-1347
if (Func->hasThisPointer()) {
+ ThisPtr = NewFrame->getThis();
if (!CheckInvoke(S, PC, NewFrame->getThis())) {
return false;
----------------
tbaeder wrote:
> aaron.ballman wrote:
> > Should we assert that `ThisPtr` is valid?
> We could only assert `!isZero()` as far as I understand, but that's part of
> what `CheckInvoke` does.
Ah, then no need.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136694/new/
https://reviews.llvm.org/D136694
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
