nickdesaulniers added a comment.

> in SelectionDAGBuilder::visitCallBr

So the issue I hit immediate is that the ValueMap SelectionDAG has maps the 
indirect destination BB to the original MBB; I can't split the edge and have 
the CallBrInst lower correctly to refer to the synthesized MBB.

I think I can reuse this commit mostly as is, just move it from codegen prepare 
to another pass.

It looks like `indirectbr-expand` _is_ enabled at `-O0` and is necessary for 
correctness IIUC.  Thoughts on moving this there, and maybe renaming the pass 
to `indirectbr-callbr-expand`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138078/new/

https://reviews.llvm.org/D138078

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to