owenpan added a comment.
I think we are close to the finishing line. Can you revisit the change to the
formatter and clean it up? For example, casting `PPLevel` to `unsigned` is
redundant now. IMO you can simply the change too.
================
Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:63
skipLine(Line, /*UnknownIndent=*/true);
- if (Line.InPPDirective ||
- (Style.IndentPPDirectives == FormatStyle::PPDIS_BeforeHash &&
- Line.Type == LT_CommentAbovePPDirective)) {
- unsigned IndentWidth =
+ if (Style.IndentPPDirectives != FormatStyle::PPDIS_None &&
+ (Line.InPPDirective ||
----------------
You don't need to add this condition.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137181/new/
https://reviews.llvm.org/D137181
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
