goldstein.w.n added a comment. In D137181#3916547 <https://reviews.llvm.org/D137181#3916547>, @owenpan wrote:
> In D137181#3916521 <https://reviews.llvm.org/D137181#3916521>, @goldstein.w.n > wrote: > >> I think we can remove the places I set `InitialPPLevel` and `OldPPLevel` but >> anything else I remove causes at least one test to fail. >> >> What did you do? Just set `PPLevel = PPBranchLevel`? > > Yes, if there is a header guard. Otherwise, set `PPLevel` to `PPBranchLevel + > 1`. That fails alot of the tests for me. I have a patch attached (applyable on this) maybe you did something different?F25244239: v1-0001-Remove-all-other-defs.patch <https://reviews.llvm.org/F25244239> Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137181/new/ https://reviews.llvm.org/D137181 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
