mizvekov added inline comments.
================
Comment at: clang/include/clang/AST/TemplateBase.h:592
+ llvm::ArrayRef<TemplateArgumentLoc> arguments() const { return Arguments; }
+ llvm::MutableArrayRef<TemplateArgumentLoc> arguments() { return Arguments; }
----------------
erichkeane wrote:
> Ooh, really? Are the use cases ones where others are modifying this
> arguments list in place? All the functions you removed seem to be 'const'.
I think there used to be something that was removed since I made these changes.
Oh well, I will just remove it then.
================
Comment at: clang/include/clang/AST/Type.h:5298
- void Profile(llvm::FoldingSetNodeID &ID, const ASTContext &Context) {
- Profile(ID, Context, getDeducedType(), getKeyword(), isDependentType(),
----------------
erichkeane wrote:
> What is happening here?
There are implementation limitations here that don't allow us to use ArrayRef
very well when it's element type is only forward declared, such as in this
header.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136602/new/
https://reviews.llvm.org/D136602
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
