ychen added a comment.
Looks straightforward to me with one suggestion.
Is the CI fail related?
================
Comment at: clang/include/clang/Sema/Sema.h:2569
+ enum class TypeAccessKind { Explicit, Implicit, Typename };
+ QualType getTypeDeclType(DeclContext *LookupCtx, TypeAccessKind AK,
----------------
I find it hard to understand this enum since it does not correlate with
wordings well and need to read code in other places to understand what it is
used for. How about using two parameters: `bool DiagCtor` (replace `AK !=
TypeAccessKind::Explicit`) and `bool IsImplicitTypename` (replace `AK ==
TypeAccessKind::Typename`) ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136533/new/
https://reviews.llvm.org/D136533
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
