mizvekov created this revision.
Herald added a project: All.
mizvekov requested review of this revision.
Herald added projects: clang, libc++.
Herald added subscribers: libcxx-commits, cfe-commits.
Herald added a reviewer: libc++.
Fixes GH58547.
Signed-off-by: Matheus Izvekov <mizve...@gmail.com>
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D136533
Files:
clang/docs/ReleaseNotes.rst
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaDecl.cpp
clang/lib/Sema/SemaTemplate.cpp
clang/test/CXX/dcl.dcl/dcl.attr/dcl.attr.deprecated/p1.cpp
libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.depr_in_cxx17.verify.cpp
Index: libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.depr_in_cxx17.verify.cpp
===================================================================
--- libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.depr_in_cxx17.verify.cpp
+++ libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.depr_in_cxx17.verify.cpp
@@ -23,7 +23,10 @@
int main(int, char**)
{
std::allocator<int> a;
- TEST_IGNORE_NODISCARD a.allocate(3, nullptr); // expected-warning {{'allocate' is deprecated}}
+ TEST_IGNORE_NODISCARD a.allocate(3, nullptr);
+ // expected-warning@-1 {{'allocate' is deprecated}}
+ // expected-warning@*:* {{'pointer' is deprecated}}
+ // expected-warning@*:* {{'const_pointer' is deprecated}}
return 0;
}
Index: clang/test/CXX/dcl.dcl/dcl.attr/dcl.attr.deprecated/p1.cpp
===================================================================
--- clang/test/CXX/dcl.dcl/dcl.attr/dcl.attr.deprecated/p1.cpp
+++ clang/test/CXX/dcl.dcl/dcl.attr/dcl.attr.deprecated/p1.cpp
@@ -58,3 +58,17 @@
FunS2 f;// No warning, entire function is deprecated, so usage here should be fine.
}
+
+namespace GH58547 {
+struct A {
+ using ta [[deprecated]] = int; // expected-note 2{{marked deprecated here}}
+};
+
+using t1 = typename A::ta; // expected-warning {{'ta' is deprecated}}
+
+template <class B1> struct B {
+ using tb = typename B1::ta; // expected-warning {{'ta' is deprecated}}
+};
+
+template struct B<A>; // expected-note {{requested here}}
+} // namespace GH58547
Index: clang/lib/Sema/SemaTemplate.cpp
===================================================================
--- clang/lib/Sema/SemaTemplate.cpp
+++ clang/lib/Sema/SemaTemplate.cpp
@@ -10958,20 +10958,15 @@
//
// FIXME: That's not strictly true: mem-initializer-id lookup does not
// ignore functions, but that appears to be an oversight.
- auto *LookupRD = dyn_cast_or_null<CXXRecordDecl>(Ctx);
- auto *FoundRD = dyn_cast<CXXRecordDecl>(Type);
- if (Keyword == ETK_Typename && LookupRD && FoundRD &&
- FoundRD->isInjectedClassName() &&
- declaresSameEntity(LookupRD, cast<Decl>(FoundRD->getParent())))
- Diag(IILoc, diag::ext_out_of_line_qualified_id_type_names_constructor)
- << &II << 1 << 0 /*'typename' keyword used*/;
-
+ QualType T =
+ getTypeDeclType(Ctx,
+ Keyword == ETK_Typename ? TypeAccessKind::Typename
+ : TypeAccessKind::Explicit,
+ Type, IILoc);
// We found a type. Build an ElaboratedType, since the
// typename-specifier was just sugar.
- MarkAnyDeclReferenced(Type->getLocation(), Type, /*OdrUse=*/false);
- return Context.getElaboratedType(Keyword,
- QualifierLoc.getNestedNameSpecifier(),
- Context.getTypeDeclType(Type));
+ return Context.getElaboratedType(
+ Keyword, QualifierLoc.getNestedNameSpecifier(), T);
}
// C++ [dcl.type.simple]p2:
Index: clang/lib/Sema/SemaDecl.cpp
===================================================================
--- clang/lib/Sema/SemaDecl.cpp
+++ clang/lib/Sema/SemaDecl.cpp
@@ -169,6 +169,25 @@
return false;
}
+QualType Sema::getTypeDeclType(DeclContext *LookupCtx, TypeAccessKind AK,
+ TypeDecl *TD, SourceLocation NameLoc) {
+ auto *LookupRD = dyn_cast_or_null<CXXRecordDecl>(LookupCtx);
+ auto *FoundRD = dyn_cast<CXXRecordDecl>(TD);
+ if (AK != TypeAccessKind::Explicit && LookupRD && FoundRD &&
+ FoundRD->isInjectedClassName() &&
+ declaresSameEntity(LookupRD, cast<Decl>(FoundRD->getParent())))
+ Diag(NameLoc,
+ AK == TypeAccessKind::Typename
+ ? diag::ext_out_of_line_qualified_id_type_names_constructor
+ : diag::err_out_of_line_qualified_id_type_names_constructor)
+ << TD->getIdentifier() << /*Type*/ 1
+ << 0 /*if any keyword was present, it was 'typename'*/;
+
+ DiagnoseUseOfDecl(TD, NameLoc);
+ MarkAnyDeclReferenced(TD->getLocation(), TD, /*OdrUse=*/false);
+ return Context.getTypeDeclType(TD);
+}
+
namespace {
enum class UnqualifiedTypeNameLookupResult {
NotFound,
@@ -332,10 +351,11 @@
bool IsClassTemplateDeductionContext,
ImplicitTypenameContext AllowImplicitTypename,
IdentifierInfo **CorrectedII) {
+ bool IsImplicitTypename = !isClassName && !IsCtorOrDtorName;
// FIXME: Consider allowing this outside C++1z mode as an extension.
bool AllowDeducedTemplate = IsClassTemplateDeductionContext &&
- getLangOpts().CPlusPlus17 && !IsCtorOrDtorName &&
- !isClassName && !HasTrailingDot;
+ getLangOpts().CPlusPlus17 && IsImplicitTypename &&
+ !HasTrailingDot;
// Determine where we will perform name lookup.
DeclContext *LookupCtx = nullptr;
@@ -359,11 +379,9 @@
// refer to a member of an unknown specialization.
// In C++2a, in several contexts a 'typename' is not required. Also
// allow this as an extension.
- if (AllowImplicitTypename == ImplicitTypenameContext::No &&
- !isClassName && !IsCtorOrDtorName)
- return nullptr;
- bool IsImplicitTypename = !isClassName && !IsCtorOrDtorName;
if (IsImplicitTypename) {
+ if (AllowImplicitTypename == ImplicitTypenameContext::No)
+ return nullptr;
SourceLocation QualifiedLoc = SS->getRange().getBegin();
if (getLangOpts().CPlusPlus20)
Diag(QualifiedLoc, diag::warn_cxx17_compat_implicit_typename);
@@ -537,18 +555,10 @@
// C++ [class.qual]p2: A lookup that would find the injected-class-name
// instead names the constructors of the class, except when naming a class.
// This is ill-formed when we're not actually forming a ctor or dtor name.
- auto *LookupRD = dyn_cast_or_null<CXXRecordDecl>(LookupCtx);
- auto *FoundRD = dyn_cast<CXXRecordDecl>(TD);
- if (!isClassName && !IsCtorOrDtorName && LookupRD && FoundRD &&
- FoundRD->isInjectedClassName() &&
- declaresSameEntity(LookupRD, cast<Decl>(FoundRD->getParent())))
- Diag(NameLoc, diag::err_out_of_line_qualified_id_type_names_constructor)
- << &II << /*Type*/1;
-
- DiagnoseUseOfDecl(IIDecl, NameLoc);
-
- T = Context.getTypeDeclType(TD);
- MarkAnyDeclReferenced(TD->getLocation(), TD, /*OdrUse=*/false);
+ T = getTypeDeclType(LookupCtx,
+ IsImplicitTypename ? TypeAccessKind::Implicit
+ : TypeAccessKind::Explicit,
+ TD, NameLoc);
} else if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(IIDecl)) {
(void)DiagnoseUseOfDecl(IDecl, NameLoc);
if (!HasTrailingDot)
Index: clang/include/clang/Sema/Sema.h
===================================================================
--- clang/include/clang/Sema/Sema.h
+++ clang/include/clang/Sema/Sema.h
@@ -2566,6 +2566,10 @@
bool isSimpleTypeSpecifier(tok::TokenKind Kind) const;
+ enum class TypeAccessKind { Explicit, Implicit, Typename };
+ QualType getTypeDeclType(DeclContext *LookupCtx, TypeAccessKind AK,
+ TypeDecl *TD, SourceLocation NameLoc);
+
ParsedType getTypeName(const IdentifierInfo &II, SourceLocation NameLoc,
Scope *S, CXXScopeSpec *SS = nullptr,
bool isClassName = false, bool HasTrailingDot = false,
Index: clang/docs/ReleaseNotes.rst
===================================================================
--- clang/docs/ReleaseNotes.rst
+++ clang/docs/ReleaseNotes.rst
@@ -255,6 +255,9 @@
- Reject non-type template arguments formed by casting a non-zero integer
to a pointer in pre-C++17 modes, instead of treating them as null
pointers.
+- Fix missing diagnostics for uses of declarations when performing typename access,
+ such as when performing member access on a '[[deprecated]]' type alias.
+ `Issue 58547 <https://github.com/llvm/llvm-project/issues/58547>`
Improvements to Clang's diagnostics
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
