craig.topper added inline comments.
================ Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8141 + i128mem, X86vpdpbssd, SchedWriteVecIMul.XMM, + 1>, T8XD; + defm VPDPBSSDY : avx_dotprod_rm<0x50,"vpdpbssd", v8i32, VR256, loadv8i32, ---------------- There are two spaces before T8XD. Same the next few instructions ================ Comment at: llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=+avxvnniint8 --show-mc-encoding | FileCheck %s --check-prefixes=X86 ---------------- This is only testing half the intrinsics. I think you test the non-S for 128 and the S for 256. ================ Comment at: llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll:6 + +declare <4 x i32> @llvm.x86.avx2.vpdpbssd.128(<4 x i32>, <4 x i32>, <4 x i32>) + ---------------- Are there tests for commuting? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
