EricWF added a reviewer: jfb. EricWF marked an inline comment as done. EricWF added a comment.
Address inline comments from @jfb and add him as a reviewer. ================ Comment at: test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp:86 @@ +85,3 @@ + // does not generate any diagnostics. + x.compare_exchange_weak(val1, val2, std::memory_order_release); + } ---------------- jfb wrote: > Could you do the other 5 (same below). I could, but we only check the two argument version of the overload, so I *know* the other orderings will have the same result. I think the one test is sufficient because it will fail the second we start testing the one argument version. Do you still want the additional tests? https://reviews.llvm.org/D22557 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
