domada marked an inline comment as done.
domada added inline comments.

================
Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:1871
+  }
+}
+TEST_F(OpenMPIRBuilderTest, ApplySimdlen) {
----------------
jdoerfert wrote:
> This doesn't actually test that 2 assumes with alignments have been found, 
> one for each alloca.
The latest change moved `alloca` handling to the Clang. That's why it is not 
necessary to check it here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133578/new/

https://reviews.llvm.org/D133578

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to