xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.

This change look good to me. I am not entirely sure about the future plans 
though. We should be able to read the values out from the AST, so we do not 
need the store to map memregions to values (as far as the values inside the 
object are concerned). How to deal with the address of such object is a good 
question, but a special symbol or constant might be an alternative to 
introducing memregions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135763/new/

https://reviews.llvm.org/D135763

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to