HazardyKnusperkeks added a reviewer: Vigilans.
HazardyKnusperkeks added a comment.
In D129443#3844535 <https://reviews.llvm.org/D129443#3844535>, @owenpan wrote:

> In D129443#3842427 <https://reviews.llvm.org/D129443#3842427>, 
> @HazardyKnusperkeks wrote:
>
>> We can //fix// that regression, and I will adopt this change for my company 
>> to keep the requires expressions where they are. :)
>
> Then we have three options:
>
> 1. Only fix the "regression".
> 2. Add the option and make `OuterScope` the default.
> 3. Add the option and make `Keyword` the default.
>
> @HazardyKnusperkeks I will defer to your choice. :)

Add the option, and then either way we will have a regression to somebody. 
`OuterScope` will regress to version 15. `Keyword` up to 14. So it should be 
the most reasonable to make `OuterScope` the default, since the early adapters 
will most be more open to change their configuration.

@rymiel please add a change log note about that changed default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129443/new/

https://reviews.llvm.org/D129443

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to