mwyman marked 2 inline comments as done.
mwyman added inline comments.
================
Comment at: clang/lib/CodeGen/CGObjC.cpp:1116
+// for the `_cmd` argument that no longer exists for direct methods.
+static llvm::Value *emitCmdLoadForGetterSetterBody(CodeGenFunction &CGF,
+ ObjCMethodDecl *MD) {
----------------
ahatanak wrote:
> Since this is loading from an uninitialized alloca, can we just pass an
> `undef` to the call to `objc_get/setProperty`? The optimization passes will
> just do that, but we can still reduce the code size at `-O0`.
Great suggestion! Done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135091/new/
https://reviews.llvm.org/D135091
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
