mwyman marked an inline comment as done.
mwyman added inline comments.
================
Comment at: clang/test/CodeGenObjC/direct-method.m:171-177
+// Check the synthesized objectProperty calls objc_getProperty(); this also
+// checks that the synthesized method accesses _cmd (or rather loads the
+// selector, as it is an argument to objc_getProperty).
+// CHECK-LABEL: define hidden i8* @"\01-[Root objectProperty]"(
+// CHECK-LABEL: objc_direct_method.cont:
+// CHECK-NEXT: load i8*, i8** @OBJC_SELECTOR_REFERENCES_
+// CHECK: call i8* @objc_getProperty({{.*}})
----------------
stephanemoore wrote:
> I'm not intricately familiar with the codegen checking mechanism in these
> tests but without fully knowing the details, this seems consistent with the
> checks in `-[Root accessCmd]` above which I would expect to require similar
> checks.
>
> Did you check that these added tests reproduce the previous assertion/failure
> so that we can be confident that the code changes resolve the issue?
Yes, this new test previously triggered the assertion.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135091/new/
https://reviews.llvm.org/D135091
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
