python3kgae added a comment.

In D133993#3840838 <https://reviews.llvm.org/D133993#3840838>, @efriedma wrote:

> It seems like it would be better to put the code in an LLVM IR transform 
> pass, if we can. It separates the concerns more clearly, and it would make 
> life easier for other compilers.  (If you need it to run early, see 
> registerPipelineEarlySimplificationEPCallback.)
>
> I won't block the patch on that, though.

Thanks for the review.
I like the idea to move code to LLVM IR pass.
I'll commit this PR as is, and create another one to move the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133993/new/

https://reviews.llvm.org/D133993

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to