efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

It seems like it would be better to put the code in an LLVM IR transform pass, 
if we can. It separates the concerns more clearly, and it would make life 
easier for other compilers.  (If you need it to run early, see 
registerPipelineEarlySimplificationEPCallback.)

I won't block the patch on that, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133993/new/

https://reviews.llvm.org/D133993

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to