akyrtzi marked an inline comment as done.
akyrtzi added inline comments.
================
Comment at: clang/include/clang/AST/DeclObjC.h:1091
virtual void collectPropertiesToImplement(PropertyMap &PM,
PropertyDeclOrder &PO) const {}
----------------
akyrtzi wrote:
> benlangmuir wrote:
> > Can we use the existing `PropertyDeclOrder` instead of changing the map
> > type? Or else get rid of the `PO` parameter to functions using
> > `PropertyMap` if we keep the MapVector?
> I'll take a look.
See updated patch.
The diagnostic machinery (e.g. in `DiagnoseUnimplementedProperties`) for these
ObjC diagnostics is using `PropertyMap` separately from the
`collectPropertiesToImplement` functions, so I kept the map type change and
removed `PropertyDeclOrder` from these functions accepting `PropertyMap`.
This is better for maintainance since it'd be an easy mistake to add new code
that iterates the `DenseMap` instead of the vector.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135118/new/
https://reviews.llvm.org/D135118
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
