[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

[Argyrios Kyrtzidis via Phabricator via cfe-commits]

akyrtzi added inline comments.


================
Comment at: clang/include/clang/AST/DeclObjC.h:1091
   virtual void collectPropertiesToImplement(PropertyMap &PM,
                                             PropertyDeclOrder &PO) const {}
 
----------------
benlangmuir wrote:
> Can we use the existing `PropertyDeclOrder` instead of changing the map type? 
> Or else get rid of the `PO` parameter to functions using `PropertyMap` if we 
> keep the MapVector?
I'll take a look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135118/new/

https://reviews.llvm.org/D135118

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits