MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Driver/Driver.cpp:6195 + + assert(false && "Unhandled Mode"); + return "clang"; ---------------- MaskRay wrote: > If the switch covers all enum members, we typically use llvm_unreachable to > work around a GCC -Wswitch warning. > Clang correctly knows all branches are covered and do not need > `llvm_unreachable` `llvm_unreachable` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
