MaskRay added a comment.
Thanks. The previous behavior is too magical. I like this version.
================
Comment at: clang/docs/ReleaseNotes.rst:243
+ ``<target>.cfg`` and ``<driver>.cfg`` if the former is not found. `Target`
+ is always the effective target (with respect to ``-target``, ``-m32``, etc.)
+ and `driver` first tries the canonical name for the driver (respecting
----------------
`-target` => `--target=`
avoid legacy spelling
================
Comment at: clang/test/Driver/config-file3.c:33
+// RUN: ln -s %clang %t/testdmode/x86_64-unknown-linux-gnu-clang
+// RUN: echo > %t/testdmode/x86_64-unknown-linux-gnu-clang++.cfg
+// RUN: echo > %t/testdmode/x86_64-unknown-linux-gnu-clang-g++.cfg
----------------
Since %t is rebuilt. You can just use `touch`
================
Comment at: clang/test/Driver/config-file3.c:47
+// FULL1: Configuration file:
{{.*}}/testdmode/x86_64-unknown-linux-gnu-clang++.cfg
+// FULL1-NOT: Configuration file:
{{.*}}/testdmode/x86_64-unknown-linux-gnu-clang-g++.cfg
+// FULL1-NOT: Configuration file:
{{.*}}/testdmode/x86_64-unknown-linux-gnu-clang.cfg
----------------
Is `// FULL1-NOT: Configuration file:` sufficient?
================
Comment at: clang/test/Driver/config-file3.c:62
//
-// RUN: %t/testdmode/qqq-clang-g++ --config-system-dir=
--config-user-dir=%t/testdmode -c -### %s 2>&1 | FileCheck %s -check-prefix
SYMLINK
+// FULL1-I386-NOT: Configuration file:
{{.*}}/testdmode/x86_64-unknown-linux-gnu-clang++.cfg
+// FULL1-I386-NOT: Configuration file:
{{.*}}/testdmode/x86_64-unknown-linux-gnu-clang-g++.cfg
----------------
Is // FULL1-NOT: Configuration file: sufficient?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134337/new/
https://reviews.llvm.org/D134337
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
