mstorsjo added a comment.

LGTM from my perspective now too.



================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4493
+
+  if (Args.hasArg(options::OPT__SLASH_Zl)) {
+    CmdArgs.push_back("-D_VC_NODEFAULTLIB");
----------------
If I understand correctly, we still don't have any corresponding gcc style 
driver flag for this? Would you consider adding that in a separate, later patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133457/new/

https://reviews.llvm.org/D133457

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to