tingwang added a comment. > It looks like the only change needed for ppc would be to remove the > `!DirectTy->isStructTy()` check here? (I guess to avoid inadvertently > change other targets, this might need to be triggered by a flag passed as > argument. On the other hand, maybe there is no other big-endian platform > using `emitVoidPtrVAArg` anyway?)
Thank you! Looked a little bit into history: the `!DirectTy->isStructTy()` check is specifically added in https://reviews.llvm.org/D21611. I will update patch to add a flag for PPC64 passed as argument. During investigate, I noticed an issue caused by transition to opaque-pointer in test case introduced by D21611 <https://reviews.llvm.org/D21611>: the case CHECK-NOT contains typed pointer will not match clang generated opaque-pointer in any way, so these tests are invalidated and here is risk until these test cases are updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133338/new/ https://reviews.llvm.org/D133338 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
