jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed.
I think the code as is upstream is fine. The test input is problematic. There is no guarantee, or even any argument, that stdbool is not included by the compiler or any header (system or not). If the user writes conflicting cod with the system, that calls for problems down the line. Long story short, I'd abandon this for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131639/new/ https://reviews.llvm.org/D131639 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
