steakhal planned changes to this revision. steakhal added a comment. In D132236#3752209 <https://reviews.llvm.org/D132236#3752209>, @NoQ wrote:
>> So, what you are suggesting here is an alternative solution to the one you >> already proposed in your last comment? > > I was just expanding the initial suggestion but also symbol reaper is too > complicated for me to make such suggestions confidently. So I'm just sharing > some ideas but you'll probably have to dig deeper to understand whether > they're correct. I see. I very much appreciate any suggestions. Many thanks. >> Unfortunately, we found many FPs introduced by this change; so this should >> be definitely blocked. > > Interesting, I didn't expect that. It could be insanely valuable to make > tests out of those so that future generations didn't make the same mistake! > Symbol reaper seems to be very under-tested for its complexity. I agree. We were also surprised. I havent spent the time to understand the root cause, as only a single path resulted in a 160Mb+ html. So far I can tell that it messed up something including lambdas capturing by reference. I find it always difficult to catch "what is missing" from the puzzle in such cases. Its much easier to catch if something has a wrong binding etc. We'll see how much effort it takes to reduce. For FPs I dont know how to automate this process. :/ Lets see when we get back to this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132236/new/ https://reviews.llvm.org/D132236 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
