NoQ added a comment. > So, what you are suggesting here is an alternative solution to the one you > already proposed in your last comment?
I was just expanding the initial suggestion but also symbol reaper is too complicated for me to make such suggestions confidently. So I'm just sharing some ideas but you'll probably have to dig deeper to understand whether they're correct. > Unfortunately, we found many FPs introduced by this change; so this should be > definitely blocked. Interesting, I didn't expect that. It could be insanely valuable to make tests out of those so that future generations didn't make the same mistake! Symbol reaper seems to be very under-tested for its complexity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132236/new/ https://reviews.llvm.org/D132236 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
