xazax.hun added inline comments.
================
Comment at: clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:332
+
+ if (LeftSubVar == RightSubVar) {
+ // `X <=> (A <=> A)` is equvalent to `X` which is already in
----------------
xazax.hun wrote:
> I wonder why this simplification is done here only for `BiconditionalValue`.
> Other operations seem to not do these sorts of simplifications. Also, when
> would we take this branch? `getOrCreateIff` has a special case when both
> operands are the same.
Oh, looking at the other patch I see it mentioning desugaring. So can
desugaring also introduce `Biconditional`s?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130519/new/
https://reviews.llvm.org/D130519
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
