aaron.ballman added a comment.

I'm in C standards meetings this week and don't have a lot of ability to 
thoroughly review this yet, but the most immediate concern which springs to 
mind for me is that this is exposing LLVM implementation details to users. 
Users should not have to think about things in terms of LLVM IR markings like 
poison and undef, and I worry that this is an expert-only feature that will be 
easy to misuse and introduce security issues. It sounds like there's an 
extremely specific use case in mind for this attribute; is there a reason why 
this needs to be the user's problem instead of something the compiler can infer 
or handle on the backend?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130224/new/

https://reviews.llvm.org/D130224

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D130224:... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D13... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D13... Matt Arsenault via Phabricator via cfe-commits
    • [PATCH] D13... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D13... Matt Arsenault via Phabricator via cfe-commits
    • [PATCH] D13... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D13... Nicolai Hähnle via Phabricator via cfe-commits
    • [PATCH] D13... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D13... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D13... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D13... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D13... Matt Arsenault via Phabricator via cfe-commits

Reply via email to