Mogball added inline comments.
================ Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:238 + // Stores the mapping between an operand and its BFS traversal information. + DenseMap<Value, OperandBFS *> operandToItsBFSMap; + ---------------- srishti-pm wrote: > Mogball wrote: > > Why can't you sort the OperandBFS directly to avoid the hash map? > Because comparators are not allowed to modify their input arguments. The arguments have to be const references? If so, just const_cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
