srishti-pm marked an inline comment as done.
srishti-pm added inline comments.


================
Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:238
+    // Stores the mapping between an operand and its BFS traversal information.
+    DenseMap<Value, OperandBFS *> operandToItsBFSMap;
+
----------------
Mogball wrote:
> Why can't you sort the OperandBFS directly to avoid the hash map?
Because comparators are not allowed to modify their input arguments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124750/new/

https://reviews.llvm.org/D124750

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to