vaibhav.y added inline comments.
================ Comment at: clang/lib/Basic/Sarif.cpp:161 + Region["endColumn"] = adjustColumnPos( + R.getEnd(), Lexer::MeasureTokenLength(R.getEnd().getLocWithOffset(0), + R.getEnd().getManager(), LO)); ---------------- aaron.ballman wrote: > I didn't catch this during the review -- but this is a layering violation > that caused link errors on some of the build bots. Lexer can call into Basic, > but Basic cannot call into Lexer. So we'll need to find a different way to > handle this. Would moving the code to Support, having it depend on Basic & Lex work? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
