aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
Unfortunately, I had to roll this back in 7a3918b540c30cc630aaae9124c67e5e4db123c2 <https://reviews.llvm.org/rG7a3918b540c30cc630aaae9124c67e5e4db123c2> because there's a layering violation. I've commented on it in the review. ================ Comment at: clang/lib/Basic/Sarif.cpp:161 + Region["endColumn"] = adjustColumnPos( + R.getEnd(), Lexer::MeasureTokenLength(R.getEnd().getLocWithOffset(0), + R.getEnd().getManager(), LO)); ---------------- I didn't catch this during the review -- but this is a layering violation that caused link errors on some of the build bots. Lexer can call into Basic, but Basic cannot call into Lexer. So we'll need to find a different way to handle this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
