njames93 created this revision.
njames93 added reviewers: sammccall, kadircet.
Herald added subscribers: usaxena95, arphaman.
Herald added a project: All.
njames93 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
In
https://github.com/llvm/llvm-project/commit/6e566bc5523f743bc34a7e26f050f1f2b4d699a8,
The directory structure of the documentation for clang-tidy checks was
changed, however clangd wasn't updated.
Now all the links generated will point to old dead pages.
This updated clangd to use the new page structure.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D128379
Files:
clang-tools-extra/clangd/Diagnostics.cpp
clang-tools-extra/clangd/test/diagnostics-tidy.test
Index: clang-tools-extra/clangd/test/diagnostics-tidy.test
===================================================================
--- clang-tools-extra/clangd/test/diagnostics-tidy.test
+++ clang-tools-extra/clangd/test/diagnostics-tidy.test
@@ -9,7 +9,7 @@
# CHECK-NEXT: {
# CHECK-NEXT: "code": "bugprone-sizeof-expression",
# CHECK-NEXT: "codeDescription": {
-# CHECK-NEXT: "href":
"https://clang.llvm.org/extra/clang-tidy/checks/bugprone-sizeof-expression.html";
+# CHECK-NEXT: "href":
"https://clang.llvm.org/extra/clang-tidy/checks/bugprone/sizeof-expression.html";
# CHECK-NEXT: },
# CHECK-NEXT: "message": "Suspicious usage of 'sizeof(K)'; did you mean
'K'?",
# CHECK-NEXT: "range": {
Index: clang-tools-extra/clangd/Diagnostics.cpp
===================================================================
--- clang-tools-extra/clangd/Diagnostics.cpp
+++ clang-tools-extra/clangd/Diagnostics.cpp
@@ -918,9 +918,18 @@
// information to be worth linking.
// https://clang.llvm.org/docs/DiagnosticsReference.html
break;
- case Diag::ClangTidy:
- return {("https://clang.llvm.org/extra/clang-tidy/checks/"; + Name +
".html")
+ case Diag::ClangTidy: {
+ StringRef Module, Check;
+ // This won't correctly get the module for clang-analyzer checks, but as we
+ // don't link in the analyzer that shouldn't be an issue.
+ // This would also need updating if anyone decides to create a module with
a
+ // '-' in the name.
+ std::tie(Module, Check) = Name.split('-');
+ assert(!Module.empty() && !Check.empty());
+ return {("https://clang.llvm.org/extra/clang-tidy/checks/"; + Module + "/" +
+ Check + ".html")
.str()};
+ }
case Diag::Clangd:
if (Name == "unused-includes")
return {"https://clangd.llvm.org/guides/include-cleaner"};
Index: clang-tools-extra/clangd/test/diagnostics-tidy.test
===================================================================
--- clang-tools-extra/clangd/test/diagnostics-tidy.test
+++ clang-tools-extra/clangd/test/diagnostics-tidy.test
@@ -9,7 +9,7 @@
# CHECK-NEXT: {
# CHECK-NEXT: "code": "bugprone-sizeof-expression",
# CHECK-NEXT: "codeDescription": {
-# CHECK-NEXT: "href": "https://clang.llvm.org/extra/clang-tidy/checks/bugprone-sizeof-expression.html";
+# CHECK-NEXT: "href": "https://clang.llvm.org/extra/clang-tidy/checks/bugprone/sizeof-expression.html";
# CHECK-NEXT: },
# CHECK-NEXT: "message": "Suspicious usage of 'sizeof(K)'; did you mean 'K'?",
# CHECK-NEXT: "range": {
Index: clang-tools-extra/clangd/Diagnostics.cpp
===================================================================
--- clang-tools-extra/clangd/Diagnostics.cpp
+++ clang-tools-extra/clangd/Diagnostics.cpp
@@ -918,9 +918,18 @@
// information to be worth linking.
// https://clang.llvm.org/docs/DiagnosticsReference.html
break;
- case Diag::ClangTidy:
- return {("https://clang.llvm.org/extra/clang-tidy/checks/"; + Name + ".html")
+ case Diag::ClangTidy: {
+ StringRef Module, Check;
+ // This won't correctly get the module for clang-analyzer checks, but as we
+ // don't link in the analyzer that shouldn't be an issue.
+ // This would also need updating if anyone decides to create a module with a
+ // '-' in the name.
+ std::tie(Module, Check) = Name.split('-');
+ assert(!Module.empty() && !Check.empty());
+ return {("https://clang.llvm.org/extra/clang-tidy/checks/"; + Module + "/" +
+ Check + ".html")
.str()};
+ }
case Diag::Clangd:
if (Name == "unused-includes")
return {"https://clangd.llvm.org/guides/include-cleaner"};
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
