njames93 added inline comments.
================
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:928
+ std::tie(Module, Check) = Name.split('-');
+ assert(!Module.empty() && !Check.empty());
+ return {("https://clang.llvm.org/extra/clang-tidy/checks/"; + Module + "/" +
----------------
sammccall wrote:
> I don't think we should assert on this, how clang-tidy checks are named isn't
> something clangd can reasonably control.
>
> Instead I'd suggest only returning a value if the condition is met.
The logic behind the assert was that it wouldn't cause any issues on release,
but if someone added a check not to the convention it would break debug builds.
But it's not an issue that's expected anyway so can be safely removed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128379/new/
https://reviews.llvm.org/D128379
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
