aaron.ballman accepted this revision.
aaron.ballman added a comment.

I remain concerned about the utility of this check. As I understand it, the 
more complete Unicode guidance is still under active discussion and hasn't been 
finalized (please correct me if I'm wrong @tahonermann and @cor3ntin) so it 
feels a bit premature to land this. It also doesn't follow the guidance from 
the Unicode consortium and expected to have more false positives.

That said, I don't have a strong enough technical reason to block this check, 
so it gets my disgaree-but-LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112916/new/

https://reviews.llvm.org/D112916

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to